mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71241: Added a `distcheck` target to the cmake build.
Date Tue, 03 Sep 2019 14:51:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71241/
-----------------------------------------------------------

(Updated Sept. 3, 2019, 4:51 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Changes
-------

Add a `TODO` on checking `install` target


Repository: mesos


Description
-------

This patch adds a `distcheck` target to the cmake build which mimics the
target of the same name provided by the autotools build. `distcheck`
depends on the `dist` target to create a distribution archive and then
ensures that with the distributed sources the `check` targets succeeds.


Diffs (updated)
-----

  CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
  cmake/distcheck.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71241/diff/3/

Changes: https://reviews.apache.org/r/71241/diff/2-3/


Testing
-------

`ninja distcheck` passes, no artifacts left around but tarball.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message