mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71240: Added a `dist` target to the cmake build.
Date Tue, 03 Sep 2019 13:52:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
-----------------------------------------------------------

(Updated Sept. 3, 2019, 3:52 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Changes
-------

Address issues raised by Benno


Repository: mesos


Description
-------

This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.

While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.

This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.


Diffs (updated)
-----

  CMakeLists.txt dc50dd457585c14a456ca710da4a16a0d45ef17a 
  cmake/dist.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71240/diff/2/

Changes: https://reviews.apache.org/r/71240/diff/1-2/


Testing
-------

`ninja dist` produces a tarball, no artifacts left around but tarball.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message