mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@d2iq.com>
Subject Re: Review Request 71385: Added restart logic for failing resource providers.
Date Tue, 03 Sep 2019 13:28:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71385/#review217546
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/daemon.cpp
Lines 536 (patched)
<https://reviews.apache.org/r/71385/#comment304805>

    Should we restart here? Though the future currently won't be set to ready, it might do
that in the future. If a resource provider is exited normally, is it supposed to be restarted?


- Jan Schlicht


On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71385/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2019, 11:12 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8400
>     https://issues.apache.org/jira/browse/MESOS-8400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds restart logic to the resource provider daemon. We now
> watch launched providers and restart them should they become terminal.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/daemon.cpp 2fd82ad5749e3948c590ce5e9816566a3627b885 
>   src/resource_provider/local.hpp 75ce0f2e4a744685f2b701ecce269995f5ddaafb 
>   src/resource_provider/storage/provider.hpp ccd09dfe826d89c2775939bf132697956429c289

>   src/resource_provider/storage/provider.cpp f180af8c17f735acb18029b6e4cf2942b5536bf4

>   src/tests/storage_local_resource_provider_tests.cpp 05daf2a19145d0da2672bbaa5ae061369b2504f5

> 
> 
> Diff: https://reviews.apache.org/r/71385/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message