mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71399: Renamed `allocate` and its derivatives in HierarchialAllocatorProcess.
Date Tue, 03 Sep 2019 13:23:45 GMT


> On Aug. 30, 2019, 12:28 a.m., Meng Zhu wrote:
> > src/master/allocator/mesos/hierarchical.hpp
> > Lines 780-781 (original), 779-780 (patched)
> > <https://reviews.apache.org/r/71399/diff/1/?file=2163097#file2163097line781>
> >
> >     Same as the previous patch, should this just be `trackOffered`? Ditto for untrack
> 
> Andrei Sekretenko wrote:
>     No, definitely not.
>     
>     Unlike similar `Slave`'s method from the previous patch, this one is also called
in various resovery scenarios. In those cases some of the resources might be actually used
by task/executor.

Some cases in which both offered and alllocated can be tracked/untracked:


https://github.com/apache/mesos/blob/7e30597783f9501faab02b930f26a19eeb666989/src/master/allocator/mesos/hierarchical.cpp#L602
https://github.com/apache/mesos/blob/7e30597783f9501faab02b930f26a19eeb666989/src/master/allocator/mesos/hierarchical.cpp#L641

Probably I have to leave this pair as it is for now, as the suggested name might be misleading
as well. Leaving this as TODO.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71399/#review217499
-----------------------------------------------------------


On Sept. 3, 2019, 1:23 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71399/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2019, 1:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
>     https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the `HierarchialAllocatorProcess` code more consistent
> with naming of different subsets of resources in the master
> (where "resource belongs to `offered`" is equivalent to "there is an
> offer with this resource", "resource belongs to `allocated`"
> is equivalent to "there is a task/executor with this resource" and
> `offered` has no intersection with `allocated`).
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 65d103ea18b91adbdde3b0eb85113a1c0f4d990c

>   src/master/allocator/mesos/hierarchical.cpp dd73d5b46c95ac7827d39ed93e0da097f4e8937a

>   src/master/allocator/mesos/metrics.cpp f8465bef90815827c97ac2886d00c03a333f4df3 
> 
> 
> Diff: https://reviews.apache.org/r/71399/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message