mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71398: Made `allocated` mean "allocated but not offered" in `allocator::Slave`.
Date Tue, 03 Sep 2019 13:16:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71398/
-----------------------------------------------------------

(Updated Sept. 3, 2019, 1:16 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Relpaced `track/untrackOfferedOrAllocated()` with `decrease/increaseAvailable()`


Summary (updated)
-----------------

Made `allocated` mean "allocated but not offered" in `allocator::Slave`.


Bugs: MESOS-9949
    https://issues.apache.org/jira/browse/MESOS-9949


Repository: mesos


Description (updated)
-------

This patch makes the `allocator::Slave` code more consistent
with naming of different subsets of resources in the master
(where "resource belongs to `offered`" is equivalent to "there is an
offer with this resource", "resource belongs to `allocated`"
is equivalent to "there is a task/executor with this resource" and
`offered` has no intersection with `allocated`).


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 65d103ea18b91adbdde3b0eb85113a1c0f4d990c 
  src/master/allocator/mesos/hierarchical.cpp dd73d5b46c95ac7827d39ed93e0da097f4e8937a 


Diff: https://reviews.apache.org/r/71398/diff/2/

Changes: https://reviews.apache.org/r/71398/diff/1-2/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message