mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 71240: Added a `dist` target to the cmake build.
Date Tue, 03 Sep 2019 13:08:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/#review217539
-----------------------------------------------------------




cmake/dist.sh
Lines 8 (patched)
<https://reviews.apache.org/r/71240/#comment304789>

    Why this restriction if we're going to create the tarball from a clean checkout anyways?



cmake/dist.sh
Lines 19 (patched)
<https://reviews.apache.org/r/71240/#comment304793>

    I'm not sure if this is written down anywhere, but in general it's a good shell-script
best practice to use `SCREAMING_CASE` for variables that can be overriden from outside and
`lower_case` for variables that are internal to the script.



cmake/dist.sh
Lines 21 (patched)
<https://reviews.apache.org/r/71240/#comment304790>

    Can we find a more speaking name than `D` for this? Also, since this is used as a temporary
directory it might make sense to use `mktemp -d` rather than hardcoding the directory name.



cmake/dist.sh
Lines 29 (patched)
<https://reviews.apache.org/r/71240/#comment304797>

    Can you explain why in-tree builds are not supported, i.e. why do we need to create a
separate build directory here?



cmake/dist.sh
Lines 33 (patched)
<https://reviews.apache.org/r/71240/#comment304791>

    I assume `nproc` is some magic cmake variable that is set automatically?


- Benno Evers


On Aug. 6, 2019, 7:28 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71240/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2019, 7:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a `dist` target to the cmake build, analogous to the
> target provided by the autotools build.
> 
> While cmake already provides a `package_source` target to create a
> source archive it does not take care of only including relevant files,
> but instead adds all files to the archive, e.g., including build or
> backup files which should not be part of a release. For that reason this
> patch introduces a script which performs a temporary `git clone` from
> the checked out git repository and creates the archive from that clean
> tree.
> 
> This patch also removes a hardcoded list of ignored files which was
> by design not exhaustive.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 65bfbac0e2b6aec26a6d98ff96615661210ceac2 
>   cmake/dist.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71240/diff/1/
> 
> 
> Testing
> -------
> 
> `ninja dist` produces a tarball, no artifacts left around but tarball.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message