mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@d2iq.com>
Subject Re: Review Request 71384: Passed down failures into resource provider fatal handler.
Date Tue, 03 Sep 2019 13:02:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71384/#review217541
-----------------------------------------------------------


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Line 268 (original), 268 (patched)
<https://reviews.apache.org/r/71384/#comment304794>

    Let's not use `Failure` here, as this class is meant to represent a failed future. Use
`string` instead.


- Jan Schlicht


On Aug. 28, 2019, 11:12 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71384/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2019, 11:12 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-8400
>     https://issues.apache.org/jira/browse/MESOS-8400
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In a follow-up patch we will surface failures up the stack.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp f180af8c17f735acb18029b6e4cf2942b5536bf4

> 
> 
> Diff: https://reviews.apache.org/r/71384/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message