mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71395: Implemented snapshot bot.
Date Mon, 02 Sep 2019 12:50:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71395/#review217534
-----------------------------------------------------------


Fix it, then Ship it!





support/mesos-snapshot.sh
Lines 23 (patched)
<https://reviews.apache.org/r/71395/#comment304788>

    This is weird since we usually only skip these scripts into a Jenkins and non-Jenkins
part if the script can be run outside of CI.
    
    I'd suggest we get `M2_DIR` via `mvn help:evaluate -Dexpression=settings.localRepository
| grep -v '[INFO]'`; alternatively inline this whole script into the Jenkins script.


- Benjamin Bannier


On Aug. 28, 2019, 6:41 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71395/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2019, 6:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-9955
>     https://issues.apache.org/jira/browse/MESOS-9955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Dockerized the snapshot building process.
> 
> 
> Diffs
> -----
> 
>   support/jenkins/snapshotbot.sh PRE-CREATION 
>   support/mesos-snapshot.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71395/diff/1/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message