mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71359: Optimized the allocation loop.
Date Fri, 23 Aug 2019 18:05:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71359/#review217402
-----------------------------------------------------------


Ship it!




Nice one!


src/master/allocator/mesos/hierarchical.cpp
Line 2084 (original), 2102-2106 (patched)
<https://reviews.apache.org/r/71359/#comment304684>

    now that it's written this way, maybe put `guaranteesAllocation + ...` at the front?



src/master/allocator/mesos/hierarchical.cpp
Lines 2086-2113 (original), 2108-2135 (patched)
<https://reviews.apache.org/r/71359/#comment304685>

    Not for this review, just noticing that it might read easier if we have additionalScalarAllocation
more contained (e.g. in a lambda)



src/master/allocator/mesos/hierarchical.cpp
Lines 2225-2226 (original), 2241-2242 (patched)
<https://reviews.apache.org/r/71359/#comment304686>

    maybe:
    
    Reservations (including the role's ancestors' reservations), non-scalar ...


- Benjamin Mahler


On Aug. 23, 2019, 4:55 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71359/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2019, 4:55 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9806
>     https://issues.apache.org/jira/browse/MESOS-9806
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Master + previous patch:
> 
> HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Made 3500 allocations in 20.58648254secs
> Made 0 allocation in 17.705055744secs
> 
> Master + previous patch + this patch:
> 
> HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Made 3500 allocations in 15.635489759secs
> Made 0 allocation in 14.291803907secs
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 649de3b635a1ab95554406b0f7a061095f484ca4

> 
> 
> Diff: https://reviews.apache.org/r/71359/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message