mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71361: Added missing `return` statement in `Slave::statusUpdate`.
Date Fri, 23 Aug 2019 15:11:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71361/#review217400
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Aug. 23, 2019, 8:57 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71361/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2019, 8:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, if `statusUpdate` was called for a pending task, it would
> forward the status update and then continue executing `statusUpdate`,
> which then checks if there is an executor that is aware of this task.
> Given that a pending task is not known to any executor, it would always
> handle it by forwarding status update one more time. This patch adds
> missing `return` statement, which fixes the issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 1d0ec9d2428c3ffa28ad3e960b74f171013cf0c2 
> 
> 
> Diff: https://reviews.apache.org/r/71361/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message