mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 71357: Used boost `small_vector` in `Resources`.
Date Fri, 23 Aug 2019 00:24:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71357/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-9806
    https://issues.apache.org/jira/browse/MESOS-9806


Repository: mesos


Description
-------

Without this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 22.065721878secs
Made 0 allocation in 19.467366742secs

With this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 20.58648254secs
Made 0 allocation in 17.705055744secs


Diffs
-----

  include/mesos/resources.hpp e5e87a04b42ebd277d02100dd49b8e2ce98fdc04 
  include/mesos/v1/resources.hpp 6a9751af967ed29ae77dc1c3e34453a306eae9d2 


Diff: https://reviews.apache.org/r/71357/diff/1/


Testing
-------

make check
Benchmark result in the description


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message