mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71347: Optimized shrinkResources.
Date Thu, 22 Aug 2019 22:34:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71347/
-----------------------------------------------------------

(Updated Aug. 22, 2019, 10:34 p.m.)


Review request for mesos, Andrei Sekretenko and Meng Zhu.


Changes
-------

* Pulled out other optimizations in front of this patch.


Bugs: MESOS-9806
    https://issues.apache.org/jira/browse/MESOS-9806


Repository: mesos


Description (updated)
-------

The shrinkResources function now is a friend of Resources,
in order to perform an in-place shuffle of the vector.

Master + previous patches:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 23.37 secs
Made 0 allocation in 19.72 secs

Master + previous patches + this patch:
*HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Made 3500 allocations in 21.71 secs
Made 0 allocation in 18.49 secs


Diffs (updated)
-----

  include/mesos/resources.hpp a6a052ba51e13e2804eca846f08605e7f0714cfd 
  src/common/resources_utils.cpp 720b954b74a5db72438b1846d7df837d6a1fa4a4 


Diff: https://reviews.apache.org/r/71347/diff/2/

Changes: https://reviews.apache.org/r/71347/diff/1-2/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message