mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71316: Added draining tests for empty agents.
Date Thu, 22 Aug 2019 18:34:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71316/
-----------------------------------------------------------

(Updated Aug. 22, 2019, 11:34 a.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
-------

* Increased grace period argument for normal draining test.
* Removed two (somewhat redundant) state checks in the normal draining tests.
* Added verification of unreachability in one test.
* Added verification of drained state in one test.


Bugs: MESOS-9892
    https://issues.apache.org/jira/browse/MESOS-9892


Repository: mesos


Description
-------

This splits the existing agent draining tests into two variants:
1) where the agent has nothing running, and
2) where the agent has one task running.


Diffs (updated)
-----

  src/tests/master_draining_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71316/diff/2/

Changes: https://reviews.apache.org/r/71316/diff/1-2/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message