mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71315: Refactored master draining test setup.
Date Thu, 22 Aug 2019 18:31:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71315/
-----------------------------------------------------------

(Updated Aug. 22, 2019, 11:31 a.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
-------

Removed Credential argument from HTTP Post helper function.


Bugs: MESOS-9892
    https://issues.apache.org/jira/browse/MESOS-9892


Repository: mesos


Description
-------

Tests of this feature will generally require a master, agent, framework,
and a single task to be launched at the beginning of the test.
This moves this common code into the test SetUp.

This also changes the `post(...)` helper to return the http::Response
object instead of parsing it.  The response for DRAIN_AGENT calls
does not return an object, so the tests were not checking the
response before.


Diffs (updated)
-----

  src/tests/master_draining_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71315/diff/2/

Changes: https://reviews.apache.org/r/71315/diff/1-2/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message