mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71174: Recovered network info for nested/standalone containers in CNI isolator.
Date Thu, 22 Aug 2019 07:07:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71174/#review217375
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71174]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 22, 2019, 1:19 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71174/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2019, 1:19 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9909
>     https://issues.apache.org/jira/browse/MESOS-9909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recovered network info for nested/standalone containers in CNI isolator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto 3e5b66702be5c042ef6c7c580cbcbf6afd3167f0 
>   src/common/protobuf_utils.hpp 5d6a35d6e3bae35b83e87827724206f7c5dfb2d8 
>   src/common/protobuf_utils.cpp 64777c0e2f28aba6cd34cbdd92b914485f8d73e7 
>   src/slave/containerizer/mesos/containerizer.cpp 9030af1463d7de7f339e1b39f0c4eeb24c5d3105

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 8d037334a8e449408918c584eade9ac6bc93337c

> 
> 
> Diff: https://reviews.apache.org/r/71174/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message