-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71310/#review217363
-----------------------------------------------------------
Ship it!
I think we should at least try to expose QuotaConfig atm.
src/master/http.cpp
Lines 2725-2726 (patched)
<https://reviews.apache.org/r/71310/#comment304657>
This makes me wonder if we should make `RoleResourceBreakdown` scalar only.
- Meng Zhu
On Aug. 19, 2019, 1:34 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71310/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2019, 1:34 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
>
>
> Bugs: MESOS-9758
> https://issues.apache.org/jira/browse/MESOS-9758
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This endpoint is meant to expose resource statistics, and only
> accidentally exposed the metadata and non-scalar resources. It
> does not make sense to expose non-scalar resources in this way.
>
> The `resources` field will be deprecated in favor of a breakdown
> between offered, allocated, and reserved resources (similar to
> the /roles endpoint).
>
>
> Diffs
> -----
>
> src/master/http.cpp 6400771acd2ad7d8948bad7ff8e1eb7fe4546347
> src/master/master.hpp 09a70dfa7ae306b4de4c688e3b4b4576b610e351
> src/master/readonly_handler.cpp b226ae1fb1c4ff8ae2cde7e359d4fb1eb5b1b163
> src/tests/api_tests.cpp e202cd330d424efef783d39b74db5f856bd34895
>
>
> Diff: https://reviews.apache.org/r/71310/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
|