mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71338: Moved OpenSSL-related ifdef to a central location.
Date Wed, 21 Aug 2019 13:36:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71338/#review217353
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Benno for fixing my ugly patch.


3rdparty/libprocess/src/openssl.cpp
Lines 55 (patched)
<https://reviews.apache.org/r/71338/#comment304641>

    As nicely noted by BenjaminB in my previous less beautiful RR, we might want to explain
what version this was; "(OpenSSL 1.1.0)" as done above.


- Till Toenshoff


On Aug. 21, 2019, 1:34 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71338/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2019, 1:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A previous commit introduced an preprocessor directive that would
> split up code between brackets, confusing syntax highlighters and
> making the logic hard to read.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp 4aeab855b29837dc6bf93104afc62f111c38626c 
> 
> 
> Diff: https://reviews.apache.org/r/71338/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message