mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71318: Added agent reactivations to the existing agent draining tests.
Date Tue, 20 Aug 2019 17:28:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71318/
-----------------------------------------------------------

(Updated Aug. 20, 2019, 10:28 a.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
-------

The extra `Clock::advance()` was triggering an additional status update if the agent did not
receive the ACK in time.  This makes the tests wait for the ACK.


Bugs: MESOS-9892
    https://issues.apache.org/jira/browse/MESOS-9892


Repository: mesos


Description
-------

This adds an extra step to a couple of the agent draining tests,
which calls REACTIVATE_AGENT at the end.


Diffs (updated)
-----

  src/tests/master_draining_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71318/diff/2/

Changes: https://reviews.apache.org/r/71318/diff/1-2/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message