mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71301: Added a framework id field to the allocator Framework struct.
Date Tue, 20 Aug 2019 14:59:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217335
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.cpp
Line 556 (original), 557 (patched)
<https://reviews.apache.org/r/71301/#comment304632>

    Hmm... honestly, I didn't realize that this signature (and also `updateFramework()`'s)
had the same issue for a long time (likely since the moment when the "id" field was added
into `FrameworkInfo`).
    
    Makes me wonder if we can change these signatures. 
    If we cannot - maybe it makes more sense to 
    `CHECK_EQ(frameworkInfo.id(), frameworkId);`
    instead of 
    `CHECK(frameworkInfo.has_id()); CHECK(frameworkInfo.id().value() != "");` ?


- Andrei Sekretenko


On Aug. 16, 2019, 10:53 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2019, 10:53 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This provides easy lookup.
> 
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 035fd3d7892d4280e299a29f99e8cf6a4c2afb30

>   src/master/allocator/mesos/hierarchical.cpp b8b9241eae20691ed52c9b5759b17f88a0d8931f

> 
> 
> Diff: https://reviews.apache.org/r/71301/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message