mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."
Date Tue, 20 Aug 2019 11:49:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71207/
-----------------------------------------------------------

(Updated Aug. 20, 2019, 1:49 p.m.)


Review request for mesos and Till Toenshoff.


Changes
-------

Rebase


Bugs: MESOS-9630
    https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
-------

This reverts commit c0f8f56d5a93f3fb870e448fedfd22f1491356ca.

This patch was necessary when we were running cpplint via
`support/mesos-style.py` to prevent it from cluttering up the hook
output. When running under pre-commit linter output is not shown if no
errors occur so we can undo our change to stay closer to upstream.


Diffs (updated)
-----

  support/cpplint.py 66ec8b3636a8d3ba57becd8560b4fe394e7119d8 


Diff: https://reviews.apache.org/r/71207/diff/3/

Changes: https://reviews.apache.org/r/71207/diff/2-3/


Testing
-------

* used for development for a couple of months
* reports no issues in the current source tree


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message