mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71297: Fixed a flaky operation reconciliation test.
Date Mon, 19 Aug 2019 14:21:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71297/#review217291
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71297]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 19, 2019, 12:36 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71297/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2019, 12:36 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9928
>     https://issues.apache.org/jira/browse/MESOS-9928
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The FrameworkReconciliationRaceWithUpdateSlave test from the
> operation reconciliation tests was flaky since we did not wait
> for the scheduler to reconnect before attempting to send a
> subscribe call.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 9d084c027ec2f910515cafebf715f7428c43f1a9

> 
> 
> Diff: https://reviews.apache.org/r/71297/diff/2/
> 
> 
> Testing
> -------
> 
> `./src/mesos-tests --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*"
--gtest_repeat=200` while simultaneously running `stress-ng` in the background.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message