mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71301: Added a framework id field to the allocator Framework struct.
Date Mon, 19 Aug 2019 14:00:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71301/#review217290
-----------------------------------------------------------




src/master/allocator/mesos/hierarchical.hpp
Lines 83 (patched)
<https://reviews.apache.org/r/71301/#comment304582>

    What is wrong with `FrameworkInfo.id()`? Do we really need a separate parameter for an
id?


- Andrei Sekretenko


On Aug. 16, 2019, 10:53 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71301/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2019, 10:53 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This provides easy lookup.
> 
> Also refactored related functions to take in `Framework&`
> instead of `FrameworkId&`.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788

>   src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378

> 
> 
> Diff: https://reviews.apache.org/r/71301/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message