mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71174: Recovered network info for nested/standalone containers in CNI isolator.
Date Fri, 16 Aug 2019 07:52:09 GMT


> On Aug. 16, 2019, 4:45 a.m., Gilbert Song wrote:
> > Is it possible to avoid adding container_info in state?
> > 
> > This is a public facing API change. No longer can be chagned again once public module
start adopting it

Unless we let CNI isolator itself persist container_info, I am afraid that adding container_info
in state is the only way that we can get container_info during recovery because currently
containerizer is the only one who perisists container_info (as part of `ContainerConfig`).
Before this patch, in `ContainerState` we only have container_info for top-level containers
but not for any nested containers, I think container_info is a useful info for recovering
nested containers too, and there may be other isolators needs such info to do recovery as
well in future, so I think it should not be harmful.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71174/#review217229
-----------------------------------------------------------


On July 29, 2019, 4:40 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71174/
> -----------------------------------------------------------
> 
> (Updated July 29, 2019, 4:40 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9909
>     https://issues.apache.org/jira/browse/MESOS-9909
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recovered network info for nested/standalone containers in CNI isolator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/containerizer.proto a60c96302a6cec90ecd0a0885b844fff8d37db71 
>   src/common/protobuf_utils.hpp 5d6a35d6e3bae35b83e87827724206f7c5dfb2d8 
>   src/common/protobuf_utils.cpp 7778e7f2475e9d6125d1c599715c91715f3654d3 
>   src/slave/containerizer/mesos/containerizer.cpp a01edc8793a2eaa655f1729a01a01f1f61fbf7cb

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f2989cf7a2161154bb7d9bf2112bee8dd3cc5cf5

> 
> 
> Diff: https://reviews.apache.org/r/71174/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message