mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71137: Added a test to ensure composing containerizer preserves request order.
Date Wed, 14 Aug 2019 19:26:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71137/#review217210
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71289, 71137]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 14, 2019, 4:12 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71137/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2019, 4:12 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
> 
> 
> Bugs: MESOS-9887
>     https://issues.apache.org/jira/browse/MESOS-9887
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to ensure composing containerizer preserves request order.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/composing_containerizer_tests.cpp 4236bd4ea97f5d2cf91601de34b89e63c85a6fa9

>   src/tests/containerizer/mock_containerizer.hpp 8700257a9347199ed6e32b8b6b2a58787d68af03

>   src/tests/slave_tests.cpp 1a926029a9f81eb0c43e9cddd73c318557760c27 
> 
> 
> Diff: https://reviews.apache.org/r/71137/diff/1/
> 
> 
> Testing
> -------
> 
> 1. manual testing described in MESOS-9887
> 2. internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message