mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 70096: Moved cpplint configuration into dedicated file.
Date Wed, 14 Aug 2019 11:25:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70096/
-----------------------------------------------------------

(Updated Aug. 14, 2019, 1:25 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description (updated)
-------

With this change we not only reduce the amount of code in
`support/mesos-style.py` in favor of a configuration supported by
upstream, but we also make it easier to interoperate with editor
integrations for cpplint.


Diffs (updated)
-----

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  support/CPPLINT.cfg PRE-CREATION 
  support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27 


Diff: https://reviews.apache.org/r/70096/diff/3/

Changes: https://reviews.apache.org/r/70096/diff/2-3/


Testing
-------

* confirmed that `./support/mesos-style.py src/executor/executor.cpp` still does what is expected
* no new warnings when running over the whole codebase


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message