mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71283: Made sure we are tracking ephemeral quota before getting the usage.
Date Wed, 14 Aug 2019 03:28:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71283/#review217193
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71283]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 13, 2019, 10:59 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71283/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2019, 10:59 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9935
>     https://issues.apache.org/jira/browse/MESOS-9935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If there is no ephemeral disk resource, the `disk/du` isolator
> will not track ephemeral disk usage. In that case, we can't index
> the paths hash to find the last usage since it doesn't contain the
> ephemeral paths. The fix is to check, and omit the ephemeral usage
> if it is not being tracked.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 29bdbe6ccffd755df4dc48983c5f99fc2f0ae5d2

> 
> 
> Diff: https://reviews.apache.org/r/71283/diff/1/
> 
> 
> Testing
> -------
> 
> make check with empty disk resources
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message