mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 71275: Fixed agent draining when returning from unreachable state.
Date Tue, 13 Aug 2019 21:13:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71275/
-----------------------------------------------------------

(Updated Aug. 13, 2019, 2:13 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, and Greg Mann.


Changes
-------

Fixed the problem with marking stuff drained too early if operations exist.
Fixed race in unit test.


Bugs: MESOS-9934
    https://issues.apache.org/jira/browse/MESOS-9934


Repository: mesos


Description (updated)
-------

This logic was missing from the initial implementation of agent
draining.  When an agent became unreachable, and then reregistered
with the master, the master would not properly deactivate or drain
the agent.

This also fixes a potential problem with checking the agent
drain state too early in the case of pending operations.
Operations are not reported to the master until after the agent
reregisters, so agents with the RESOURCE_PROVIDER capability
cannot be considered DRAINED until after the first 
UpdateSlaveMessage has arrived.


Diffs (updated)
-----

  src/master/master.cpp 31c7c97abecb92591369b417e2ef38a99cc09bac 
  src/tests/api_tests.cpp c2099674e742eaa08134c5e0a7cdab1734808119 


Diff: https://reviews.apache.org/r/71275/diff/2/

Changes: https://reviews.apache.org/r/71275/diff/1-2/


Testing
-------

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message