mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 71264: Cleared filters upon unsuppressing a role.
Date Tue, 13 Aug 2019 19:44:59 GMT


> On Aug. 12, 2019, 6:24 p.m., Meng Zhu wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1343 (original), 1347 (patched)
> > <https://reviews.apache.org/r/71264/diff/1/?file=2160402#file2160402line1347>
> >
> >     reviveRole might be a better function name?

Yeah.. good point!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71264/#review217157
-----------------------------------------------------------


On Aug. 9, 2019, 9:43 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71264/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2019, 9:43 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9932
>     https://issues.apache.org/jira/browse/MESOS-9932
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per MESOS-9932, removal of a role from the suppression list does
> not currently clear filters. This means that schedulers have to
> issue a separate explicit REVIVE for the roles they want to remove.
> 
> This ensures that filters are cleared upon removing a role from
> the suppression list.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033

> 
> 
> Diff: https://reviews.apache.org/r/71264/diff/1/
> 
> 
> Testing
> -------
> 
> Test added in subsequent patch.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message