mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71277: Guarded access to possibly destructed resource provider driver.
Date Tue, 13 Aug 2019 14:48:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71277/#review217179
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71272, 71277]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 13, 2019, 9:30 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71277/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2019, 9:30 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9560
>     https://issues.apache.org/jira/browse/MESOS-9560
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We provide a method to tear down a resource provider driver which
> internally resets the resource provider HTTP driver pointer. We need to
> prevent access to the pointed to value once the driver has been torn
> down.
> 
> This patch switches all internal uses of the the driver to `send` data
> to use a public interface method instead. We also make sure that that
> public method does not access an invalidated pointed to value.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 73b6e424e8f611cf72f102fa13a6773e2865ddbf 
> 
> 
> Diff: https://reviews.apache.org/r/71277/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran `ResourceProviderManagerHttpApiTest.ResourceProviderSubscribeDisconnect` under enormous
system `stress-ng`.
> 
> * before this patch: 5/413 failures; failure rate 0.01±0.07 (CL=67%)
> * after this patch: 0/1273 failures; failure rate <0.04 (CL=67%)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message