mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 71263: Re-wrote the quota documentation to reflect quota limits.
Date Mon, 12 Aug 2019 18:51:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71263/#review217159
-----------------------------------------------------------



Thanks for adding this. I like the brevity of the doc!

I think we should at least try to explain consumptions a bit. We mentioned this a few times
in the doc, and it also shows up in the UI and endpoint response.
Maybe a note after viewing qutoa.

- A role's quota consumption includes both allocated an reserved. The latter is accounted
even if it is not allocated. Outstanding offered resources are not charged against quota.


docs/quota.md
Line 94 (original), 77-78 (patched)
<https://reviews.apache.org/r/71263/#comment304435>

    I suggest removing this point, since
    
    - This is a minor low-level detail. 
    - It also could be confusing if the reader thinks offered resources is also part of the
consumption.
    - This might change in the future if do admission control when accepting offers.


- Meng Zhu


On Aug. 9, 2019, 9:53 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71263/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2019, 9:53 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Bugs: MESOS-9427
>     https://issues.apache.org/jira/browse/MESOS-9427
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This takes a simpler approach compared to the previous version,
> which explained too many details that were not important for the
> user to understand.
> 
> This also documents that quota guarantees are deprecated and why.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md dd09845899a304885f12fa2e7682527ec9590a59 
>   docs/quota.md c42d5cd69a4534a71879e29be49b7fd7d9d075f6 
> 
> 
> Diff: https://reviews.apache.org/r/71263/diff/1/
> 
> 
> Testing
> -------
> 
> Review the rendered version here:
> 
> https://gist.github.com/bmahler/f85b67f5c7d0f2d7970d37a926f0d778
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message