mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 71272: Dispatched invocations of RP mock default actions.
Date Mon, 12 Aug 2019 13:50:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71272/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Chun-Hung Hsiao.


Bugs: MESOS-9560
    https://issues.apache.org/jira/browse/MESOS-9560


Repository: mesos


Description
-------

When invoking member functions of the mock resource provider
`TestResourceProviderProcess` from default mock actions we need to
ensure that the mock object remains alive for the duration of the
invocation.

This patch replaces direct invocations which might run on any thread
(e.g., also while the mock object is being destructed on another thread)
which safe `dispatch`es of the default methods.


Diffs
-----

  src/tests/mesos.hpp 73b6e424e8f611cf72f102fa13a6773e2865ddbf 


Diff: https://reviews.apache.org/r/71272/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message