mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 71255: Fixed and improved `Sorter::remove` function.
Date Thu, 08 Aug 2019 19:34:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71255/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Bugs: MESOS-9930
    https://issues.apache.org/jira/browse/MESOS-9930


Repository: mesos


Description
-------

There is a bug in the remove() function where after collapsing
and turning an internal node into an leaf node, the new node's
position needs to updated in the parent's children list.
See MESOS-9930.

This patch fixes the bug and also refactored the function logic.


Diffs
-----

  src/master/allocator/mesos/sorter/drf/sorter.cpp 40397f7111d92dccecd15c9bc1ad7c45abbd850b

  src/master/allocator/mesos/sorter/random/sorter.cpp b480aeee38f87dca852ad3c8f97bb4fe993ce068



Diff: https://reviews.apache.org/r/71255/diff/1/


Testing
-------

make check

dedicated test added in r/71256/


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message