mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 71249: Added a unit test for the docker volume chown support.
Date Thu, 08 Aug 2019 08:33:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71249/#review217118
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1270 (patched)
<https://reviews.apache.org/r/71249/#comment304380>

    s/relative/absolute/ since I see the volume created in this test is with an absolute path.



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1273 (patched)
<https://reviews.apache.org/r/71249/#comment304382>

    s/read/write/ since I see you use `test -w` in this test.



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1275 (patched)
<https://reviews.apache.org/r/71249/#comment304381>

    I think we need `UNPRIVILEGED_USER_` in the test name to use `SUDO_USER` in the test.
And then we do not need `NonRootUser` in the test name.



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1400-1401 (patched)
<https://reviews.apache.org/r/71249/#comment304383>

    I think here we just check volume name but not volume parameters/options.


- Qian Zhang


On Aug. 8, 2019, 2:59 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71249/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2019, 2:59 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-9908
>     https://issues.apache.org/jira/browse/MESOS-9908
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a unit test for the docker volume chown support.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp cd5c028991b0ef2438dd5c61a08d48747a109585

> 
> 
> Diff: https://reviews.apache.org/r/71249/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message