mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71241: Added a `distcheck` target to the cmake build.
Date Tue, 06 Aug 2019 22:37:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71241/#review217107
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71240, 71241]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 6, 2019, 7:28 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71241/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2019, 7:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a `distcheck` target to the cmake build which mimics the
> target of the same name provided by the autotools build. `distcheck`
> depends on the `dist` target to create a distribution archive and then
> ensures that with the distributed sources the `check` targets succeeds.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 65bfbac0e2b6aec26a6d98ff96615661210ceac2 
>   cmake/distcheck.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71241/diff/1/
> 
> 
> Testing
> -------
> 
> `ninja distcheck` passes, no artifacts left around but tarball.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message