mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Review Request 71240: Added a `dist` target to the cmake build.
Date Tue, 06 Aug 2019 19:28:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71240/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Till Toenshoff.


Repository: mesos


Description
-------

This patch adds a `dist` target to the cmake build, analogous to the
target provided by the autotools build.

While cmake already provides a `package_source` target to create a
source archive it does not take care of only including relevant files,
but instead adds all files to the archive, e.g., including build or
backup files which should not be part of a release. For that reason this
patch introduces a script which performs a temporary `git clone` from
the checked out git repository and creates the archive from that clean
tree.

This patch also removes a hardcoded list of ignored files which was
by design not exhaustive.


Diffs
-----

  CMakeLists.txt 65bfbac0e2b6aec26a6d98ff96615661210ceac2 
  cmake/dist.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/71240/diff/1/


Testing
-------

`ninja dist` produces a tarball, no artifacts left around but tarball.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message