mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 71196: Updated the `disk/du` isolator to support rootfs checks.
Date Mon, 05 Aug 2019 21:18:14 GMT


> On Aug. 5, 2019, 3:30 p.m., Andrei Budnik wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp
> > Lines 271 (patched)
> > <https://reviews.apache.org/r/71196/diff/3/?file=2158808#file2158808line271>
> >
> >     missing `&`:
> >     ```
> >     const Resources& quota = quotas[info->sandbox];
> >     ```

This is deliberate, since we are mutating the hashmap. The spec is for references to elements
to not be invalidated, but I think that's a little non-obvious.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71196/#review217077
-----------------------------------------------------------


On Aug. 2, 2019, 1:40 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71196/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2019, 1:40 a.m.)
> 
> 
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9900
>     https://issues.apache.org/jira/browse/MESOS-9900
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the `disk/du` isolator to support isolating rootfs ephemeral
> volumes. We need to keep track of the ephemeral paths and start a `du`
> check for each one of them, but otherwise treat them in the same way
> as the sandbox path.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp f513dfc55a6e680ca451586015f98f91e0b6abc5

>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 4869c72f77ea15978496f66997c63b07276d85f0

> 
> 
> Diff: https://reviews.apache.org/r/71196/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check (Frdora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message