mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 71193: Supported multiple quota paths in the `disk/xfs` isolator.
Date Mon, 05 Aug 2019 09:17:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71193/
-----------------------------------------------------------

(Updated Aug. 5, 2019, 9:17 a.m.)


Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.


Changes
-------

Address review feedback.


Bugs: MESOS-9900
    https://issues.apache.org/jira/browse/MESOS-9900


Repository: mesos


Description
-------

The `disk/xfs` isolator assumed that there would only be a single
directory path for each project quota. When we apply project quotas
to the overlayfs upperdir, that won't be true any more, since the
upperdir will come under the same quota as the task sandbox.

Update the quota reclamation tracking to keep a set of disk paths that
the quota has been applied to, and only reclaim the project ID once all
those paths have been removed.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/xfs/disk.hpp 94d44e7f39dc01037461015b499a1fc3169b24e8

  src/slave/containerizer/mesos/isolators/xfs/disk.cpp 646330c65b24aa28801ec99d7909db08a3e05c79



Diff: https://reviews.apache.org/r/71193/diff/4/

Changes: https://reviews.apache.org/r/71193/diff/3-4/


Testing
-------

sudo make check (Frdora 30)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message