mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71232: Renamed cmake parameter for parallel test execution.
Date Fri, 02 Aug 2019 09:28:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71232/#review217051
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71232]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 2, 2019, 12:15 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71232/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2019, 12:15 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Till Toenshoff.
> 
> 
> Bugs: MESOS-6382
>     https://issues.apache.org/jira/browse/MESOS-6382
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Jenkins setup (which uses `support/docker-build.sh` under the
> covers) is parameterized with the  `CONFIGURATION` environment variable.
> While in we pass configure-style flags for both autotools and cmake
> builds to it in the Jenkins
> configuration, the script performs transformations so that
> configure-style flags are transformed to cmake-style (replace `_` with
> `-`, uppercase flags, replace `--` with `-D`).
> 
> We disable parallel test execution in Jenkins by passing
> `--disable-parallel-test-execution` which with the transformations in
> `support/docker-build.sh` leads to a cmake arg
> `-DDISABLE_PARALLEL_TEST_EXECUTION=1`. This patch renames the cmake arg
> from a default enabled `ENABLE_PARALLEL_TEST_EXECUTION` to a default
> disabled `DISABLE_PARALLEL_TEST_EXECUTION` to support this workflow.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake ca8d406e1be9d6ab50c6c9dc4d2de97189b17b9a 
> 
> 
> Diff: https://reviews.apache.org/r/71232/diff/2/
> 
> 
> Testing
> -------
> 
> Tested ctest behavior with both the new flag enabled and disabled.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message