mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 71150: Factored out storage provider method to update resources.
Date Fri, 02 Aug 2019 07:24:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/#review216947
-----------------------------------------------------------



I'm not sure if this is


src/resource_provider/storage/provider.cpp
Lines 292 (patched)
<https://reviews.apache.org/r/71150/#comment304250>

    Did you accidentally add a new line?



src/resource_provider/storage/provider.cpp
Lines 728 (patched)
<https://reviews.apache.org/r/71150/#comment304270>

    How about merging this function and `reconcileStoragePools` since the logic is very similar?



src/resource_provider/storage/provider.cpp
Lines 730 (patched)
<https://reviews.apache.org/r/71150/#comment304182>

    Remove this debug log.



src/resource_provider/storage/provider.cpp
Lines 735 (patched)
<https://reviews.apache.org/r/71150/#comment304183>

    Remove this debug log.


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71150/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
>     https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Factored out storage provider method to update resources.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072

> 
> 
> Diff: https://reviews.apache.org/r/71150/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message