mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71230: Moved the sorter code under the `master/allocator/mesos/`.
Date Fri, 02 Aug 2019 02:47:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71230/#review217046
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71230]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Aug. 2, 2019, 12:30 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71230/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2019, 12:30 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The sorter interface is designed and used by the built-in
> hierarchical allocator. It is not intended to be used
> by other allocators. This patch moves it under the built-in
> mesos allocator folder for structural clarity.
> 
> 
> Diffs
> -----
> 
>   docs/allocation-module.md 81f9d0c294eeb23f475c787da9f53f9c219bf6c3 
>   src/CMakeLists.txt e0200eb5e685cdac543defc8cda40b7452340c80 
>   src/Makefile.am d27d4b697cef034b44f89c198158a794ee52de4d 
>   src/local/local.cpp 68dc9fb0331e070ee10aee62e78381d76a52b7b0 
>   src/master/allocator/mesos/hierarchical.hpp d2658bc8997202b17bac0f765bd4f522ebee350e

>   src/master/allocator/sorter/drf/metrics.hpp  
>   src/master/allocator/sorter/drf/metrics.cpp ece151c79b1ba7728b7ce338e74d2c682a1ef4f2

>   src/master/allocator/sorter/drf/sorter.hpp 84c33ca49c5288d221f82eeb968d640461867da7

>   src/master/allocator/sorter/drf/sorter.cpp 9367469132e426f0b4b66a80ad300c157fba6bf2

>   src/master/allocator/sorter/random/sorter.hpp ca687d4590387d5d788919f81fe32b43baba6b3c

>   src/master/allocator/sorter/random/sorter.cpp 9899cfd570607a60dbd7980d340a8e7d9d3e6df5

>   src/master/allocator/sorter/random/utils.hpp  
>   src/master/allocator/sorter/sorter.hpp  
>   src/tests/sorter_tests.cpp 5cd2a64cb8c06f0d27c04bc0f40d347e6e61095e 
> 
> 
> Diff: https://reviews.apache.org/r/71230/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message