mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 71194: Add `disk/xfs` isolator support for ephemeral volumes.
Date Thu, 01 Aug 2019 14:15:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71194/#review217030
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 335 (patched)
<https://reviews.apache.org/r/71194/#comment304253>

    According to this comment https://github.com/apache/mesos/blob/d8155f8125e38d145d280331146b934c2bb7c842/src/slave/containerizer/mesos/isolators/xfs/disk.cpp#L294-L301,
this condition can only be met for containers that were launched before enabling XFS-isolator?
If so, should we use `WARNING` here?



src/slave/containerizer/mesos/isolators/xfs/disk.cpp
Lines 425-426 (patched)
<https://reviews.apache.org/r/71194/#comment304255>

    Why doesn't `ephemeral_volumes` belonging to the `states` cover all directories? What
is the case when we need this?



src/slave/containerizer/mesos/provisioner/backends/overlay.cpp
Lines 17 (patched)
<https://reviews.apache.org/r/71194/#comment304256>

    Move it to the line after `#include "linux/fs.hpp"` (closer to the `#include "slave/containerizer/mesos/provisioner/constants.hpp"`)?


- Andrei Budnik


On Июль 30, 2019, 7:52 д.п., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71194/
> -----------------------------------------------------------
> 
> (Updated Июль 30, 2019, 7:52 д.п.)
> 
> 
> Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-9900
>     https://issues.apache.org/jira/browse/MESOS-9900
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add support for labeling ephemeral volumes with the sandbox XFS
> project ID. This makes changes to the container rootfs share the
> same disk quota as the sandbox.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/xfs/disk.cpp 646330c65b24aa28801ec99d7909db08a3e05c79

>   src/slave/containerizer/mesos/provisioner/backends/overlay.hpp 362e02172d2fd8e6e241fb6f5689f569ba74a0d1

>   src/slave/containerizer/mesos/provisioner/backends/overlay.cpp f2040cf36c601a13281a78ff844ebd41000a2d65

> 
> 
> Diff: https://reviews.apache.org/r/71194/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check (Frdora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message