mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 70831: Fixed synchronization in MasterTest.UpdateSlaveMessageWithPendingOffers.
Date Thu, 01 Aug 2019 08:08:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70831/#review217026
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 9014 (patched)
<https://reviews.apache.org/r/70831/#comment304251>

    Alternatively, we can avoid this expectation and do the following:
    ```
    Future<ResourceProviderID> providerId = resourceProvider->process->id();
    AWAIT_READY(providerId);
    ```
    Then s/`resourceProvider->process->info.id()`/`providerId.get()`/
    
    I'm fine with either approach so please feel free to drop this.


- Chun-Hung Hsiao


On June 11, 2019, 12:38 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70831/
> -----------------------------------------------------------
> 
> (Updated June 11, 2019, 12:38 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order for a resource provider to have been assigned and stored an
> assigned resource provider ID it needs to receive and process the
> corresponding resource provider `SUBSCRIBED` event.
> 
> This patch fixes `MasterTest.UpdateSlaveMessageWithPendingOffers` so we
> await the correct event. The test was previously awaiting an
> `UpdateSlaveMessage` which is only tangentially related, but does not
> guarantee correct event ordering.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e 
> 
> 
> Diff: https://reviews.apache.org/r/70831/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message