mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 71182: Stored last time a drain request was sent in the master.
Date Thu, 01 Aug 2019 07:52:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71182/
-----------------------------------------------------------

(Updated Aug. 1, 2019, 9:52 a.m.)


Review request for mesos and Greg Mann.


Bugs: MESOS-9907
    https://issues.apache.org/jira/browse/MESOS-9907


Repository: mesos


Description (updated)
-------

This information can be used to calculate an approximate time when
draining an agent would be finished, e.g., by comparing
`DrainConfig.max_grace_period` and the field
`estimated_drain_start_time` added here, both obtained from the master
API simultaneously. This information is necessarily approximate as the
agent might e.g., fail over before it has finished draining which would
reset the timeout; for that specific case the master would send the
drain request again so after some time the value calculated from the
master API would be in line with the expected true value.

WIP: drain start time in master


Diffs (updated)
-----

  include/mesos/master/master.proto 07bf4e7194399ef660d7282275f25e1d4563e473 
  include/mesos/v1/master/master.proto 9bcef2f358b50fd63cdfdec5dcad742930de3ecc 
  src/common/protobuf_utils.cpp 7778e7f2475e9d6125d1c599715c91715f3654d3 
  src/master/http.cpp 765d5052ab6a8d731113f8922d20fb280b843003 
  src/master/master.hpp 8bdbac90b9000e9126a7fad375642dcf0a03378e 
  src/master/readonly_handler.cpp a8931153dc1b3f204c1b6437b972fe6607f900bd 
  src/tests/api_tests.cpp 641eb15153ddb85df322aa6a133ca8e4c6d6a510 


Diff: https://reviews.apache.org/r/71182/diff/3/

Changes: https://reviews.apache.org/r/71182/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message