mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 71148: Explicitly disabled periodic reconciliation for some provider tests.
Date Fri, 26 Jul 2019 04:40:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71148/#review216877
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Line 846 (original), 846 (patched)
<https://reviews.apache.org/r/71148/#comment304121>

    How about using zero here, as described in `mesos.proto`?
    
    And since most tests require no reconciliation, maybe making zero the default in `setupResourceProviderConfig`?


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71148/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
>     https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Explicitly disabled periodic reconciliation for some provider tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e

> 
> 
> Diff: https://reviews.apache.org/r/71148/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message