mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 71147: Update config factory to set resource provider reconciliation interval.
Date Fri, 26 Jul 2019 04:38:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/#review216876
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Lines 331 (patched)
<https://reviews.apache.org/r/71147/#comment304120>

    I'm actually thinking about haveing a really short reconciliation interval for testing
here, so certain tests won't wait for a long time. WDYT?
    
    Or, maybe we can inject proper reconciliation intervals only in the tests that checks
for reconciliations.


- Chun-Hung Hsiao


On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71147/
> -----------------------------------------------------------
> 
> (Updated July 23, 2019, 8:18 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9254
>     https://issues.apache.org/jira/browse/MESOS-9254
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Update config factory to set resource provider reconciliation interval.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e

> 
> 
> Diff: https://reviews.apache.org/r/71147/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message