mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71034: Enabled the Docker executor to accept kill policy overrides.
Date Thu, 25 Jul 2019 19:24:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71034/
-----------------------------------------------------------

(Updated July 25, 2019, 7:24 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
    https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
-------

This adds a new `killTask()` overload to the Docker executor
and updates the Mesos executor driver to call into that
overload when the loaded executor is the Docker executor.

This allows the executor driver to pass the kill policy
override, when present, into the Docker executor.


Diffs (updated)
-----

  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/exec/exec.cpp c0fa3b61667da96bc4395bae9956c54446268122 


Diff: https://reviews.apache.org/r/71034/diff/3/

Changes: https://reviews.apache.org/r/71034/diff/2-3/


Testing
-------

Details at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message