mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 71033: Moved the Docker executor declaration into a header.
Date Thu, 25 Jul 2019 19:24:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71033/
-----------------------------------------------------------

(Updated July 25, 2019, 7:24 p.m.)


Review request for mesos, Benno Evers, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9853
    https://issues.apache.org/jira/browse/MESOS-9853


Repository: mesos


Description
-------

This moves the declaration of the Docker executor into the
Docker executor header file and moves the code for the Docker
executor binary into a new launcher implementation file.

This change will enable the Mesos executor driver
implementation to make use of the `DockerExecutor` symbol.


Diffs (updated)
-----

  src/CMakeLists.txt c455ed6f3205800f47c251a3b087446222da969b 
  src/Makefile.am 46c66f199e38897df5056ba4fe5f3d45643e8480 
  src/docker/CMakeLists.txt 1196664f5a7bde6d58e5e3a672da5376719e42ce 
  src/docker/executor.hpp f21e84c71f646e84404c65fc2ded64bcaff482ef 
  src/docker/executor.cpp f638e4b65155bcca1be36424b7061ea26a3d6ca3 
  src/launcher/CMakeLists.txt 2ffa946b10e59c439de747e54c2f088b271201f0 
  src/launcher/docker_executor.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71033/diff/2/

Changes: https://reviews.apache.org/r/71033/diff/1-2/


Testing
-------

Details at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message