mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 71159: Updated quota related endpoints to return quota configurations.
Date Thu, 25 Jul 2019 04:38:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71159/#review216842
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71158, 71159]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On July 25, 2019, 1:55 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71159/
> -----------------------------------------------------------
> 
> (Updated July 25, 2019, 1:55 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9598 and MESOS-9599
>     https://issues.apache.org/jira/browse/MESOS-9598
>     https://issues.apache.org/jira/browse/MESOS-9599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added quota configuration information (that includes both
> guarantees and limits) in V1 GET_QUOTA call and V0 GET "/quota".
> 
> To keep backwards compatibility, the infos field which only
> includes the guarantees are continue to be filled. An additional
> field configs was added.
> 
> Also extended an existing test to cover the changes in
> the endpoints.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 15b02b08917201c824230d649fdae265957748af 
>   src/tests/master_quota_tests.cpp 7745fb0a903c4dc5603c12049f224b3d45273a4b 
> 
> 
> Diff: https://reviews.apache.org/r/71159/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message