mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xudong Ni via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.
Date Wed, 24 Jul 2019 23:10:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71080/
-----------------------------------------------------------

(Updated July 24, 2019, 11:10 p.m.)


Review request for mesos, James Peach and Jiang Yan Xu.


Bugs: MESOS-8636
    https://issues.apache.org/jira/browse/MESOS-8636


Repository: mesos


Description
-------

It should be separately from that for webUI and endpoints.
Currently the master stores the history of completed frameworks in
a map with the full historical data of the framework, it is
prohibitively expensive to keep a long history; In order to reject
frameworks from reregistering if they have previously marked as
completed, we only need to persist the framework IDs and are able
to keep long history.


Diffs (updated)
-----

  docs/configuration/master.md c56ac8510ea968f9587e23e81ed310caa968ee9e 
  docs/operator-http-api.md 1167838928e0fcb774cf904fa6ef5e6847134e15 
  src/master/constants.hpp 26afa356b7844b4ec6c2caeef33bd39c51148d5f 
  src/master/flags.hpp 78623d68bf428cd3f52684303d98a525d42eb878 
  src/master/flags.cpp 74f4daadd48e8e691be43759b88dc8b3c2df489a 
  src/master/http.cpp 765d5052ab6a8d731113f8922d20fb280b843003 
  src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95 
  src/master/master.cpp fbde112eabf2c6da363ab313cf3f4c54f581eaa7 


Diff: https://reviews.apache.org/r/71080/diff/8/

Changes: https://reviews.apache.org/r/71080/diff/7-8/


Testing
-------

make check

sudo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter=MasterTest.MaxCompletedFrameworksFlag
--gtest_break_on_failure --gtest_repeat=1000
[       OK ] MasterTest.MaxCompletedFrameworksFlag (230 ms)
[----------] 1 test from MasterTest (235 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (281 ms total)
[  PASSED  ] 1 test.


Thanks,

Xudong Ni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message