mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 71082: Added a helper to create std::vector from iterable into python bindings.
Date Wed, 24 Jul 2019 13:35:07 GMT


> On July 23, 2019, 9:35 p.m., Benjamin Mahler wrote:
> > src/python/native_common/common.hpp
> > Lines 155-159 (patched)
> > <https://reviews.apache.org/r/71082/diff/2/?file=2157504#file2157504line155>
> >
> >     Is this still needed? Looks like a declaration of the definition above?

No, this is a different template declaration, and it is not redundant.

For non-protobufs, `enable_if<...>::type` does not exist. Thus, the first one is a *substitution
failure* for non-protobufs, and we need another template declaration for them (which should
be a substitution falure for protobufs, otherwise we get two conflicting declarations - hence
the second `enable_if`).


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71082/#review216818
-----------------------------------------------------------


On July 24, 2019, 1:34 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71082/
> -----------------------------------------------------------
> 
> (Updated July 24, 2019, 1:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9864
>     https://issues.apache.org/jira/browse/MESOS-9864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a helper to create std::vector from iterable into python bindings.
> 
> 
> Diffs
> -----
> 
>   src/python/native_common/common.hpp ed743aab014301981fe2526a7e81f4a35c02e19b 
> 
> 
> Diff: https://reviews.apache.org/r/71082/diff/3/
> 
> 
> Testing
> -------
> 
> With valid arguments - see next patches.
> Ran with invalid arguments manually.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message